Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41173: Copy test results file from ARM worker before uploading #21305

Merged
merged 3 commits into from Jul 7, 2020
Merged

bpo-41173: Copy test results file from ARM worker before uploading #21305

merged 3 commits into from Jul 7, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Jul 3, 2020 •
edited by bedevere-bot

@zooba zooba added OS-windows skip news 🔨 test-with-buildbots Test the PR with the buildbot fleet and report in the status section labels Jul 3, 2020
@bedevere-bot
Copy link

bedevere-bot commented Jul 3, 2020

🤖 New build scheduled with the buildbot fleet by @zooba for commit 01bd341 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test the PR with the buildbot fleet and report in the status section label Jul 3, 2020
paulmon
paulmon reviewed Jul 6, 2020
View changes
Tools/buildbot/test.bat
set ERR=%ERRORLEVEL%
echo where scp
where scp
echo scp %SSH_SERVER%:"%REMOTE_PYTHON_DIR%test-results.xml" "%PYTHON_SOURCE%\test-results.xml"
scp %SSH_SERVER%:"%REMOTE_PYTHON_DIR%test-results.xml" "%PYTHON_SOURCE%\test-results.xml"
Copy link
Contributor

@paulmon paulmon Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"%PYTHON_SOURCE%\test-results.xml" should be "%PYTHON_SOURCE%test-results.xml"
I don't know if the extra slash will matter to scp or not without testing.

paulmon
paulmon reviewed Jul 7, 2020
View changes
Tools/buildbot/test.bat Outdated
@@ -37,7 +37,12 @@ set TEMP_ARGS=--temp %REMOTE_PYTHON_DIR%temp

set rt_args=%rt_opts% %dashU% -rwW --slowest --timeout=1200 --fail-env-changed %regrtest_args% %TEMP_ARGS%
ssh %SSH_SERVER% "set TEMP=%REMOTE_PYTHON_DIR%temp& %REMOTE_PYTHON_DIR%PCbuild\rt.bat" %rt_args%
Copy link
Contributor

@paulmon paulmon Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to
ssh %SSH_SERVER% "set TEMP=%REMOTE_PYTHON_DIR%temp & cd %REMOTE_PYTHON_DIR% & PCbuild\rt.bat" %rt_args%

@zooba zooba merged commit 10772ec into python:master Jul 7, 2020
9 checks passed
@zooba zooba deleted the bpo-41173 branch Jul 7, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 7, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 7, 2020
@zooba @miss-islington
bpo-41173: Copy test results file from ARM worker before uploading (p…
851220b 
…ythonGH-21305)

(cherry picked from commit 10772ec)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2020

GH-21382 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this issue Jul 7, 2020
@miss-islington @zooba
bpo-41173: Copy test results file from ARM worker before uploading (G…
366cfc6 
…H-21305)

(cherry picked from commit 10772ec)

Co-authored-by: Steve Dower <steve.dower@python.org>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this issue Jul 21, 2020
@zooba @arun-mani-j
bpo-41173: Copy test results file from ARM worker before uploading (p…
c3f39ae 
…ythonGH-21305)
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Aug 20, 2020
@zooba @shihai1991
bpo-41173: Copy test results file from ARM worker before uploading (p…
4f2a589 
…ythonGH-21305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmon paulmon

Assignees
No one assigned
Labels
OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zooba @bedevere-bot @miss-islington @paulmon @the-knights-who-say-ni