Skip to content

bpo-25415: Remove confusing sentence from IOBase docstrings #31631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2022
Merged

bpo-25415: Remove confusing sentence from IOBase docstrings #31631

merged 6 commits into from
Mar 4, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Mar 1, 2022 •
edited by terryjreedy
Loading

@AlexWaygood AlexWaygood added skip news docs Documentation in the Doc dir labels Mar 1, 2022
hugovk
hugovk approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, on BPO Irit said:

Martin's patch needs to be converted to a GitHub PR and reviewed.

And this PR matches the patch:

https://bugs.python.org/file40908/no-args.patch

terryjreedy
terryjreedy requested changes Mar 1, 2022
View reviewed changes
@terryjreedy terryjreedy changed the title bpo-25415: Reworded io docstrings from 'no public constructor' to 'constructor accepts no arguments' bpo-25415: Remove confusing sentence from IOBase docstrings Mar 3, 2022
@hugovk hugovk requested review from hugovk and removed request for hugovk March 4, 2022 08:47
@terryjreedy terryjreedy added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 4, 2022
@terryjreedy terryjreedy merged commit cedd247 into python:main Mar 4, 2022
@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@slateny slateny deleted the s/io branch March 4, 2022 17:39
@terryjreedy
Copy link
Member

I saw a discussion about credit in my mailbox, but do not see it here now. I removed credit to Martin because his rewording was rejected. I could have submitted my suggestion as an alternate PR, and gotten sole credit as author, but I preferred to let slateny do the work and get it. Github automatically credits anyone who modifies an existing PR, whether by pushing from their local branch or by making comment with an accepted suggestion box. (This is a hassle when the person has not signed the CLA.) I sometimes delete credit for trivial suggestions, including some of my own.

@terryjreedy terryjreedy added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 4, 2022
@terryjreedy terryjreedy added the needs backport to 3.10 only security fixes label Mar 4, 2022
@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@terryjreedy
Copy link
Member

3.10 #31688
3.9 #31689

@terryjreedy terryjreedy removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@hugovk hugovk hugovk approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@slateny @miss-islington @terryjreedy @iritkatriel @hugovk @the-knights-who-say-ni @bedevere-bot @AlexWaygood