bpo-46841: Improve the failure stats for COMPARE_OP
#31663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweeneyde
approved these changes
Mar 3, 2022
Looks good.
We could also consider packing extended opargs into the top 13 bits of cache->mask when it fits there.
Edit: I suppose it would be difficult to do next_instr++ the correct number of times in ceval. Store how far to jump ahead for that branch as well?
29 tasks
|
@markshannon is already brainstorming ideas for how to tackle the general problem of longer jumps in faster-cpython/ideas#297 and faster-cpython/ideas#301. We should probably wait to see how that pans out first before adding a bunch of new logic to the different |
|
Feel free to add suggestions to faster-cpython/ideas#301. faster-cpython/ideas#297 is more about giving the bytecode compiler freedom to lay out basic blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the move to inline caching, jumps are getting a bit longer. This adds new category of
COMPARE_OPfailures for the (increasingly more common) case where aCOMPARE_OPinstruction is followed by anEXTENDED_ARG.New stats for a full
pyperformancerun:Specialization attempts
https://bugs.python.org/issue46841