Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fix PHP 8.1 deprecation in Response::isNotModified #45631

Merged
merged 1 commit into from Mar 4, 2022

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Mar 4, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

If an If-None-Match header is provided in the request and there's no ETag header in the response, the following deprecation notice occurs on PHP 8.1 in Response::isNotModified:

Deprecated: strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated

@carsonbot carsonbot added this to the 4.4 milestone Mar 4, 2022
@HypeMC HypeMC force-pushed the php-8.1-deprecation-in-isnotmodified branch from e436f1d to e09c579 Mar 4, 2022
@HypeMC HypeMC force-pushed the php-8.1-deprecation-in-isnotmodified branch from e09c579 to b909acf Mar 4, 2022
fabpot
fabpot approved these changes Mar 4, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Mar 4, 2022

Thank you @HypeMC.

@fabpot fabpot merged commit 3cea8e7 into symfony:4.4 Mar 4, 2022
8 of 10 checks passed
@HypeMC HypeMC deleted the php-8.1-deprecation-in-isnotmodified branch Mar 4, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants