[Asset] Update the error message when assets are not built #45669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Mar 7, 2022
| @@ -54,7 +54,7 @@ private function getManifestPath(string $path): ?string | |||
| { | |||
| if (null === $this->manifestData) { | |||
| if (!file_exists($this->manifestPath)) { | |||
| throw new \RuntimeException(sprintf('Asset manifest file "%s" does not exist.', $this->manifestPath)); | |||
| throw new \RuntimeException(sprintf('Asset manifest file "%s" does not exist. Did you forget to build the assets with npm or yarn?', $this->manifestPath)); | |||
There was a problem hiding this comment.
I think the npm and yarn are to much
Build the frontend assets could be enough imho
There was a problem hiding this comment.
I'm not sure because if we only display this --> "Did you forget to build the assets?" Many newcomers might think this is a problem to be solved in Symfony ... if we add the brief mention to "yarn" and "npm", they'll get an additional clue about how to solve this or how to better look for a solution for this.
nicolas-grekas
approved these changes
Mar 17, 2022
GromNaN
approved these changes
Mar 17, 2022
|
Thank you @javiereguiluz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error message is very precise about what happened, but not very helpful about how to solve it. I propose to improve this using the same "Did you forget ...?" pattern used in other Symfony errors.