Simplify toString #4441
Merged
Simplify toString #4441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,10 +32,10 @@ function toString(value) { | |||
| } | |||
| if (Array.isArray(value)) { | |||
| // Recursively convert values (susceptible to call stack limits). | |||
| return `${map(value, (other) => other == null ? other : toString(other))}` | |||
| return `${value.map((other) => other == null ? other : toString(other))}` | |||
There was a problem hiding this comment.
i feel () for map parameters is redundant here, can we not use
return ${value.map( other => other == null ? other : toString(other))} ?
There was a problem hiding this comment.
Its the project style. See #4418 (comment)
|
Thank you @blikblum! |
jdalton
added
issue bankruptcy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses native array map instead of custom one and assumes Symbol.prototype.toString exists