New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix46246 #46357

Open

HarsheetKakar wants to merge 3 commits into microsoft:main from HarsheetKakar:fix46246

HarsheetKakar commented Oct 14, 2021

Fixes #46246

The new error message is : An interface cannot extend a primitive type like '{0}'; an interface can only extend named types and classes

where {0} has the primitive type name e.g. any, number, string etc.

Please give feedback as this is my first PR on this repo.

The text was updated successfully, but these errors were encountered:

harsheetkakar added 2 commits


          changed error message for interface extending primitive type

24d3e55


          moved interface check to different function

typescript-bot added the For Uncommitted Bug label

microsoft-cla bot commented Oct 14, 2021 •

edited

All CLA requirements met.

Author

HarsheetKakar commented Oct 14, 2021

On a side note can someone tell me if there is a slack group (or equivalent platform)?

Contributor

orouz commented Oct 14, 2021

there's a chat on discord

Author

HarsheetKakar commented Oct 14, 2021

@HarsheetKakar

there's a chat on discord

Thanks @orouz

DanielRosenwasser requested changes

View changes

Member

DanielRosenwasser left a comment

I'm not sure of the right fix, but I think this one is too broad.

src/compiler/checker.ts Show resolved Hide resolved


          changed part of interface declaration to is extended by interface

3a7a1cc

HarsheetKakar requested a review from DanielRosenwasser

sandersn added this to Waiting on reviewers in PR Backlog

sandersn assigned DanielRosenwasser

Author

HarsheetKakar commented Dec 4, 2021

@DanielRosenwasser gentle reminder. I have applied the requested changes please let me know if it suffices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment