Clean up a load of unused dependencies, broken jake script #48214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Feel free to kill the bisect script entirely; I have an off-repo script now that I'll document eVeNtUalLy |
noshlag
approved these changes
Mar 11, 2022
andrewbranch
approved these changes
Mar 11, 2022
| @@ -109,7 +101,6 @@ | |||
| "start": "node lib/tsc", | |||
| "clean": "gulp clean", | |||
| "gulp": "gulp", | |||
| "jake": "gulp", | |||
There was a problem hiding this comment.
it's not even the last mention of jake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In cleaning up the build in prep for modulization, I noticed a load of deps are entirely unused.
There's also a bisect script that appears to have been broken since gulp was introduced a few years ago. @RyanCavanaugh I can fix this script instead, probably, but I think you said you had something new you were using anyway.