New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation of v2 and patch modification #30

Merged

whummer merged 1 commit into localstack:master from pinzon:v2-support

Dec 19, 2020

Member

pinzon commented Dec 19, 2020

As suggested in issue #20 awscli was removed from requiremnts.txt

setup.py manages the installation of awscli for each version.
Now the installation works like this:

# base package without dependencies
pip install awscli-local
# package with v1 AWS CLI
pip install awscli-local[v1]
# package with v2 AWS CLI
pip install awscli-local[v2]

An the code now verifies the awscli to modify the patch.


          installation of v2 and patch modification

c72c9f4

Member

whummer commented Dec 19, 2020

LGTM - thanks @pinzon 👍 . We'll release a new version shortly..

whummer merged commit 5b063e7 into localstack:master

pinzon mentioned this pull request

Remove awscli from dependencies #20

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet