Skip to content

Removed confusing reference to sys #31638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

davidgilbertson
Copy link
Contributor

I've removed the words "a module called sys and", the diff makes it a bit hard to see. The reference didn't seem to make sense, or at least the point seems clearer without it.

Current page: https://docs.python.org/3/reference/import.html#packages
image

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this is clearer without the reference to a module.

@JelleZijlstra
Copy link
Member

Another docs clarification I'd like to merge, cc @gvanrossum.

@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 8, 2022
@JelleZijlstra JelleZijlstra merged commit 28f84c7 into python:main Mar 8, 2022
@miss-islington
Copy link
Contributor

Thanks @davidgilbertson for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-31766 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
(cherry picked from commit 28f84c7)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 8, 2022
@bedevere-bot
Copy link

GH-31767 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
(cherry picked from commit 28f84c7)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
miss-islington added a commit that referenced this pull request Mar 8, 2022
(cherry picked from commit 28f84c7)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
miss-islington added a commit that referenced this pull request Mar 8, 2022
(cherry picked from commit 28f84c7)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
(cherry picked from commit 28f84c7)

Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants