feat(useCanvasContext): new function #1373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okxiaoliang4
reviewed
Mar 7, 2022
Suggested amends for simplifying the useCanvas2D composable. Includes additional changes to index.md documentation and demo usage, as well as DocString updates.
|
@okxiaoliang4 Updated PR with implementations of your suggested amends. Thanks :D |
This was referenced Mar 22, 2022
michealroberts
changed the title
|
Hey @okxiaoliang4 I've now refactored the code with your suggestions and I have also added dual support for '2d' and 'webgl' contexts as these are the most widely used. |
|
@michael-observerly Hi, I have initiated a pr in your warehouse to see if this can solve your needs. It has better type hints and less code. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So this PR solves the usual setup of a canvas object, whilst simultaneously making it reactive to it's background element (utilising functionality from the useElementBoundin() composable).
Closes #1346
Additional context
If this PR is acceptable, I will also extend to another 3D rendering context composable (webgl), as well as PR'ing an integration for three.js if there is an appetite for it.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).