Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onClickOutside): customizable phase #1406

Merged
merged 2 commits into from Mar 15, 2022
Merged

feat(onClickOutside): customizable phase #1406

merged 2 commits into from Mar 15, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Mar 13, 2022 •
edited

Fix #1405

Description

If we were using bubbling phase, issues like #1405 could have been fixed by appending .stop modifier. Switching to bubbling is breaking change and have different behaviour than capture phase in terms of execution order.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sibbng

This comment has been minimized.

Sign in to view
@sibbng sibbng marked this pull request as draft Mar 13, 2022
@sibbng sibbng changed the title refactor(onClickOutside): use bubbling phase feat(onClickOutside): customizable phase Mar 13, 2022
@sibbng sibbng marked this pull request as ready for review Mar 13, 2022
@sibbng sibbng mentioned this pull request Mar 13, 2022
Closed
7 tasks
@sibbng
Copy link
Member Author

@sibbng sibbng commented Mar 14, 2022

@wheatjs This is not breaking change. The initial commit was a breaking change. Then I turned it into feature addition without changing the default behaviour.

@antfu antfu merged commit c31b01e into vueuse:main Mar 15, 2022
3 checks passed
@sibbng sibbng deleted the refactor/onclickoutside-phase branch Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Can't toggle by using '@click' with onClickOutside
3 participants
@sibbng @wheatjs @antfu