Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useEventListener): support component target #1408

Merged
merged 1 commit into from Mar 16, 2022
Merged

fix(useEventListener): support component target #1408

merged 1 commit into from Mar 16, 2022
+4 −2

Conversation

okxiaoliang4
Copy link
Member

@okxiaoliang4 okxiaoliang4 commented Mar 14, 2022

Description

fix useEventListener not support component ref

Additional context

fixes: #1404 #1103

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@okxiaoliang4 okxiaoliang4 linked an issue that may be closed by this pull request Mar 14, 2022
useDraggable - draggingElement not working as expected? #1103
Closed
@antfu antfu changed the title fix(useEventListener): target not support component fix(useEventListener): support component target Mar 16, 2022
@antfu antfu merged commit 981c651 into vueuse:main Mar 16, 2022
3 checks passed
@okxiaoliang4 okxiaoliang4 deleted the hotfix/useEventListener branch Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@okxiaoliang4 @antfu