Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unrefElement): improve types #1409

Merged
merged 3 commits into from Mar 15, 2022
Merged

fix(unrefElement): improve types #1409

merged 3 commits into from Mar 15, 2022

Conversation

okxiaoliang4
Copy link
Member

@okxiaoliang4 okxiaoliang4 commented Mar 14, 2022

Description

type friendly

before:

const divRef = ref<HTMLDivElement>()
const el = unrefElement(divRef) // HTMLElement | SVGElement | undefined

after:

const divRef = ref<HTMLDivElement>()
const el = unrefElement(divRef) // HTMLDivElement | undefined

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@okxiaoliang4 okxiaoliang4 marked this pull request as ready for review Mar 14, 2022
Copy link
Member Author

@okxiaoliang4 okxiaoliang4 left a comment

self review

@antfu antfu changed the title chore(unrefElement): types fix(unrefElement): improve types Mar 15, 2022
@antfu antfu merged commit 3e19431 into vueuse:main Mar 15, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants