Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): avoid missing files in manifest #11609

Merged
merged 1 commit into from Sep 21, 2020
Merged

fix(ssr): avoid missing files in manifest #11609

merged 1 commit into from Sep 21, 2020

Conversation

posva
Copy link
Member

@posva posva commented Aug 25, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Reproduction: https://github.com/LoveofRedMoon/vue-ts-ssr-demo.git
when i run 'npm run build:win' (actually file vue-ssr-client-manifest.json => modules => any contains -1)
then 'ts-node serve/serve.ts',  the serve starts.
when visit any web (ex: localhost:8000), it will shows error 'Cannot read property 'replaceAll' of undefined'

@posva
Copy link
Member Author

@posva posva commented Aug 25, 2020

Moved from #11160

Co-authored-by: johnleider <john@vuetifyjs.com>
@posva posva force-pushed the fix/ssr-missing-file branch from 17e7dc7 to b72dd5c Compare Aug 25, 2020
@posva posva removed the semver:minor label Sep 4, 2020
@posva posva merged commit b97606c into dev Sep 21, 2020
5 checks passed
@posva posva deleted the fix/ssr-missing-file branch Sep 21, 2020
@christoph-bessei
Copy link

@christoph-bessei christoph-bessei commented Nov 3, 2020

@posva Any chance we get a release with this fix soon? Caused us a lot of headache. :)

christoph-bessei added a commit to clubdrei/vue that referenced this issue Nov 3, 2020
vuejs#11609

Also change build.dev.js to avoid the build process of Vue.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants