gh-91181: restore support for bytes on sys.path in FileFinder #31897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Mar 15, 2022
graingert
force-pushed
the
support-bytes-on-sys-path
branch
from
68b32ed to
6e553d8
Compare
graingert
force-pushed
the
support-bytes-on-sys-path
branch
from
6e553d8 to
c1ee86e
Compare
graingert
changed the title
graingert
commented
Mar 15, 2022
| path=new_path, | ||
| path_importer_cache=new_path_importer_cache, | ||
| path_hooks=new_path_hooks): | ||
| module = self.importlib.import_module('email') |
There was a problem hiding this comment.
this results in a BytesWarning: Comparison between bytes and string when bytes are added to the sys.path_importer_cache this is an existing problem for zipimport paths https://bugs.python.org/issue47026
There was a problem hiding this comment.
Looks like that's causing CI to fail as BytesWarning is considered an error. Looks like I need to go to python-dev and ask what people want to do.
There was a problem hiding this comment.
https://discuss.python.org/t/drop-supporting-bytes-on-sys-path/17225
I'm now suggesting dropping bytes support in sys.path. We will see how that conversation goes.
brettcannon
changed the title
brettcannon
approved these changes
Jul 8, 2022
Misc/NEWS.d/next/Library/2022-03-15-11-00-55.bpo-47025.oS8dt6.rst
Outdated
Show resolved
Hide resolved
brettcannon
added
needs backport to 3.10
|
Closing in favor of #31934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.