Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46721: Optimize set.issuperset() for non-set arguments #31280

Merged
merged 3 commits into from Apr 6, 2022
Merged

bpo-46721: Optimize set.issuperset() for non-set arguments #31280

merged 3 commits into from Apr 6, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 11, 2022 •
edited by bedevere-bot

@serhiy-storchaka serhiy-storchaka added the performance Performance or resource usage label Feb 11, 2022
@sweeneyde
Copy link
Member

sweeneyde commented Feb 11, 2022

Is it possible that someone is relying on some_set.issuperset(iterable) consuming all of iterable? It does seem unlikely and fragile, but I just wanted to double-check.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Feb 12, 2022

Yes, it is possible, but I do not think there is much such code. We cannot double-check this.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Mar 17, 2022

@rhettinger, could you please look at this PR and #31316?

@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 17, 2022
Merged
@serhiy-storchaka serhiy-storchaka merged commit a69a4a9 into python:main Apr 6, 2022
12 checks passed
@serhiy-storchaka serhiy-storchaka deleted the set-issuperset branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweeneyde sweeneyde

@raghavthind2005 raghavthind2005

@rhettinger rhettinger

Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@serhiy-storchaka @sweeneyde @raghavthind2005 @the-knights-who-say-ni @bedevere-bot