Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cutoutPercentage to cutout + chores #8514

Merged
merged 1 commit into from Feb 24, 2021
Merged

Rename cutoutPercentage to cutout + chores #8514

merged 1 commit into from Feb 24, 2021

Conversation

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Feb 24, 2021

  • cutoutPercentage => cutout and accepts pixels as number, percentage as string ending with '%'
  • outerRadius => radius
  • simplify getRatioAndOffset
  • add 64 step fixture for doughnut rotation/circumference combinations
@kurkle
Rename cutoutPercentage to cutout + chores
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
c152073
@kurkle kurkle added type: enhancement breaking change labels Feb 24, 2021
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Feb 24, 2021

Filename Size Change
dist/chart.esm.js 65.9 kB -41 B (0%)
dist/chart.js 83.5 kB -49 B (0%)
dist/chart.min.js 59.4 kB -16 B (0%)
dist/chunks/helpers.segment.js 18.7 kB +8 B (0%)
dist/helpers.esm.js 1.07 kB +1 B (0%)
@etimberg
etimberg reviewed Feb 24, 2021
View changes
docs/docs/getting-started/v3-migration.md Show resolved Hide resolved
@etimberg
etimberg approved these changes Feb 24, 2021
View changes
@etimberg etimberg added this to the Version 3.0 milestone Feb 24, 2021
@etimberg etimberg merged commit b06cd36 into chartjs:master Feb 24, 2021
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage increased (+0.01%) to 94.671%
Details
Coveralls - ubuntu-latest-firefox Coverage increased (+0.01%) to 94.568%
Details
Coveralls - windows-latest-chrome Coverage decreased (-0.0%) to 94.671%
Details
Coveralls - windows-latest-firefox Coverage increased (+0.01%) to 94.568%
Details
codeclimate 2 fixed issues
Details
coverage/coveralls Coverage remained the same at 94.671%
Details
@kurkle kurkle deleted the kurkle:cutout branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

Assignees
No one assigned
Labels
breaking change type: enhancement
Projects
None yet
Milestone
Version 3.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kurkle @etimberg