Skip to content

Add warning for write level rights with regards to repo secrets #15553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2022
Merged

Add warning for write level rights with regards to repo secrets #15553

merged 4 commits into from
Apr 6, 2022

Conversation

mounilKshah
Copy link
Contributor

Why:

Closes #11167

What's being changed:

Added a warning under the Using Secrets section.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Feb 17, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 17, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 17, 2022
@ramyaparimi
Copy link
Contributor

@mounilKshah
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ethomson
Copy link
Contributor

ethomson commented Mar 1, 2022

This feels like it's reiterating https://github.com/github/docs/pull/15553/files#diff-f1d86f75ef58bf6616cfcd111f4821a88984a396b9178ff20b1af709d8ffa6dfL42. I wonder if we should make improvements to that paragraph instead of duplicating the idea in a different place. What do you think? 🤔

@mounilKshah
Copy link
Contributor Author

This feels like it's reiterating https://github.com/github/docs/pull/15553/files#diff-f1d86f75ef58bf6616cfcd111f4821a88984a396b9178ff20b1af709d8ffa6dfL42. I wonder if we should make improvements to that paragraph instead of duplicating the idea in a different place. What do you think? 🤔

Thank you for the review.
Actually, #11167 asks for addition of a warning, which is why I added it. As this is my first time contributing to a documentation, I wasn't sure what would be the best way to write the warning, hence I repeated what was already mentioned in the section. If there is any better way to reframe the warning, I'll make the changes accordingly.

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/security-guides/security-hardening-for-github-actions.md Modified Original

skedwards88
skedwards88 reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I made one minor wording suggestion that I will go ahead and incorporate, then we'll get this merged down for you.

@skedwards88 skedwards88 enabled auto-merge (squash) April 6, 2022 19:01
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Apr 6, 2022
@skedwards88 skedwards88 merged commit b588d2e into github:main Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve warning for handing out write level rights with regards to repo secrets
5 participants
@mounilKshah @ramyaparimi @ethomson @skedwards88 @lucascosti