-
Notifications
You must be signed in to change notification settings - Fork 61.8k
OIDC - Adding HashiCorp Vault setup instructions #15980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@smaeda-ks Thanks so much for opening this PR. We don't accept changes made to this file I am going to close this now 💛 Thanks so much for taking your time in improving the GitHub docs 💖 |
Hi @ramyaparimi, I'm trying to understand whether you will be picking up this PR in your private repo and syncing or you're simply denying this PR at all? Can you please clarify what will you be doing next? FYI, I reached out to Kevin Alwell on this and he knows the context as well. We as HashiCorp proposing this change from our tech partner standpoint. |
Thanks so much for that clarification @smaeda-ks! We didn't realize you were a partner 💛 I'm reopening this, deleting all of the bot comments above 😅 , and we'll work with the writers to get a review. |
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
…/configuring-openid-connect-in-hashicorp-vault.md Co-authored-by: Martin Lopes <martin389@github.com>
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
1 similar comment
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
@martin389 Thank you, I've merged those suggestions. |
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
👋 Status update: This PR changes files in the |
Thank you @martin389! |
I've now recreated this PR internally, and will close this one while we work through the shipping processes. I'll be away for a few days, so I've asked the team to continue work on this, depending on their availability. Otherwise I'll be able to resume this when I'm back 👍 |
Status update: I'm continuing work to get these changes shipped, and will comment here when they're live |
Thank you for the update @martin389! |
Thank you for your work on this @martin389 - very excited this made it into the docs! |
Why:
The current page is missing the detailed Vault setup instructions:
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-hashicorp-vault
What's being changed:
Adding more Vault setup instructions.
Check off the following:
Writer impact (This section is for GitHub staff members only):