Skip to content

OIDC - Adding HashiCorp Vault setup instructions #15980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from

Conversation

smaeda-ks
Copy link

@smaeda-ks smaeda-ks commented Mar 2, 2022

Why:

The current page is missing the detailed Vault setup instructions:
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-hashicorp-vault

What's being changed:

Adding more Vault setup instructions.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Mar 2, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-hashicorp-vault.md fpt
ghec
ghes@ 3.6 3.5
fpt
ghec
ghes@ 3.6 3.5

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 2, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review triage Do not begin working on this issue until triaged by the team and removed triage Do not begin working on this issue until triaged by the team content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review labels Mar 2, 2022
@ramyaparimi
Copy link
Contributor

@smaeda-ks Thanks so much for opening this PR. We don't accept changes made to this file content/actions/deployment/security-hardening-your-deployments/** in the open source repository.

I am going to close this now 💛 Thanks so much for taking your time in improving the GitHub docs 💖

@ramyaparimi ramyaparimi closed this Mar 2, 2022
@smaeda-ks
Copy link
Author

smaeda-ks commented Mar 3, 2022

Hi @ramyaparimi, I'm trying to understand whether you will be picking up this PR in your private repo and syncing or you're simply denying this PR at all? Can you please clarify what will you be doing next?

FYI, I reached out to Kevin Alwell on this and he knows the context as well. We as HashiCorp proposing this change from our tech partner standpoint.

@janiceilene
Copy link
Contributor

Thanks so much for that clarification @smaeda-ks! We didn't realize you were a partner 💛 I'm reopening this, deleting all of the bot comments above 😅 , and we'll work with the writers to get a review.

@janiceilene janiceilene reopened this Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
@github github deleted a comment from github-actions bot Mar 3, 2022
…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

smaeda-ks and others added 2 commits July 28, 2022 18:46
…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

…/configuring-openid-connect-in-hashicorp-vault.md

Co-authored-by: Martin Lopes <martin389@github.com>
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

1 similar comment
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@smaeda-ks smaeda-ks requested a review from martin389 July 28, 2022 09:58
@smaeda-ks
Copy link
Author

@martin389 Thank you, I've merged those suggestions.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jul 28, 2022
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@martin389
Copy link
Contributor

👋 Status update:

This PR changes files in the content/actions/deployment/security-hardening-your-deployments/ directory, however, these files cannot be changed by PRs in this repo (see the automated message above). So in order to ship these changes, I'll recreate this PR in an internal repository, which will let us amend these files.

@ksatirli
Copy link

Thank you @martin389!

@github github deleted a comment from 1996kaw Jul 29, 2022
@martin389
Copy link
Contributor

I've now recreated this PR internally, and will close this one while we work through the shipping processes. I'll be away for a few days, so I've asked the team to continue work on this, depending on their availability. Otherwise I'll be able to resume this when I'm back 👍

@martin389 martin389 closed this Jul 29, 2022
@martin389
Copy link
Contributor

Status update: I'm continuing work to get these changes shipped, and will comment here when they're live

@ksatirli
Copy link

Thank you for the update @martin389!

@martin389
Copy link
Contributor

The changes are now live: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-hashicorp-vault 🎊

@ksatirli
Copy link

Thank you for your work on this @martin389 - very excited this made it into the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants