Skip to content

/vue

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless parameter to the function removeVnodes (#9910) #9914

Merged
merged 1 commit into from Apr 25, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lessfish @vue-bot @yyx990803
@lessfish
Copy link
Contributor

commented Apr 23, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yyx990803 yyx990803 merged commit 43b98fe into vuejs:dev Apr 25, 2019
3 of 5 checks passed

3 of 5 checks passed

ci/circleci: lint-flow-types Your tests failed on CircleCI
Details
ci/circleci: test-cover Your tests failed on CircleCI
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
@vue-bot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 25, 2019

Hey @hanzichi, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Kiku-Reise added a commit to Kiku-Reise/vue that referenced this pull request Jun 18, 2019

@lessfish @Kiku-Reise
refactor: remove useless parameter to the function removeVnodes (vuej… 
…s#9914)

close vuejs#9910
642ea15

dukegod added a commit to dukegod/vue that referenced this pull request Jun 21, 2019

@dukegod
Merge commit 'bad3c326a3f8b8e0d3bcf07917dc0adf97c32351' into dev 
* commit 'bad3c326a3f8b8e0d3bcf07917dc0adf97c32351': (911 commits)
  chore: update sponsors [ci skip] (vuejs#10158)
  chore: fix sponsor url [ci skip]
  chore: update sponsors [ci skip] (vuejs#10136)
  chore: update sponsors [ci skip] (vuejs#10130)
  chore: update sponsors [ci skip] (vuejs#10113)
  chore(typo): fix comment typo (vuejs#10101)
  chore: update sponsors [ci skip] (vuejs#10064)
  Create FUNDING.yml
  chore: update sponsors [ci skip] (vuejs#10031)
  chore(typo): fix README tag mismatch (vuejs#9934)
  chore(typo): fix typo in comments (vuejs#9995)
  chore: update sponsors [ci skip] (vuejs#9970)
  chore: update sponsors [ci skip] (vuejs#9933)
  fix: fix function expression regex (vuejs#9922)
  fix(types): fix global namespace declaration for UMD bundle (vuejs#9912)
  fix(compiler): Remove the warning for valid v-slot value (vuejs#9917)
  polish: add warning when .native modifier is used on native HTML elements (vuejs#9884)
  test: fix running e2e test on windows (vuejs#9909)
  refactor: remove useless parameter to the function removeVnodes (vuejs#9914)
  test: separate failing test for TS 3.4
  ...

# Conflicts:
#	packages/weex-template-compiler/build.js
#	packages/weex-vue-framework/factory.js
#	packages/weex-vue-framework/index.js
bc08291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.