Skip to content

/ asyncpg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore custom data codec for internal introspection #618

Merged
merged 1 commit into from Sep 25, 2020
Merged

Ignore custom data codec for internal introspection #618

merged 1 commit into from Sep 25, 2020

Conversation

@fantix
Copy link
Member

@fantix fantix commented Sep 17, 2020

Custom data codec may manipulate the query parameters and results, breaking the assumption of internal introspection queries. This PR disables custom data codecs for internal introspections.

Fixes: #617
@elprans
elprans reviewed Sep 17, 2020
View changes
asyncpg/protocol/prepared_stmt.pyx Outdated Show resolved Hide resolved
asyncpg/protocol/prepared_stmt.pyx Outdated Show resolved Hide resolved
asyncpg/connection.py Outdated Show resolved Hide resolved
@fantix
Copy link
Member Author

@fantix fantix commented Sep 17, 2020

Oh thank you @elprans for reviewing even this draft - I'll address the issues tonight.
@fantix fantix force-pushed the fantix:t617-introspection-custom-codec branch from f1de0ad to 821f279 Sep 18, 2020
@fantix fantix marked this pull request as ready for review Sep 18, 2020
@elprans
elprans reviewed Sep 22, 2020
View changes
asyncpg/connection.py Outdated Show resolved Hide resolved
@fantix fantix force-pushed the fantix:t617-introspection-custom-codec branch from 821f279 to a0ce948 Sep 22, 2020
@elprans
elprans reviewed Sep 22, 2020
View changes
asyncpg/connection.py Show resolved Hide resolved
@fantix fantix force-pushed the fantix:t617-introspection-custom-codec branch from a0ce948 to e41e1db Sep 24, 2020
@fantix
Ignore custom data codec for internal introspection
Verified
This commit was signed with a verified signature.
fantix Fantix King
GPG key ID: 95304B04071CCDB4 Learn about signing commits
Loading status checks…
c94d6fc 
Fixes: #617
@fantix fantix force-pushed the fantix:t617-introspection-custom-codec branch from e41e1db to c94d6fc Sep 24, 2020
@fantix fantix changed the title Disable custom data codec for internal introspection Ignore custom data codec for internal introspection Sep 24, 2020
@elprans
elprans approved these changes Sep 25, 2020
View changes
@elprans elprans merged commit e064f59 into MagicStack:master Sep 25, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fantix fantix deleted the fantix:t617-introspection-custom-codec branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elprans elprans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

set_type_codec() appears to assume a particular set_type_codec for the "char" datatype
2 participants
@fantix @elprans
You can’t perform that action at this time.