stream: add iterator helper find #41849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
benjamingr
reviewed
Feb 4, 2022
vweevers
reviewed
Feb 4, 2022
| on the stream at once. **Default:** `1`. | ||
| * `signal` {AbortSignal} allows destroying the stream if the signal is | ||
| aborted. | ||
| * Returns: {Promise} a promise evaluating to the first chunk for which `fn` |
There was a problem hiding this comment.
Is it "chunk" or "item"? Let's choose one and use that throughout documentation
There was a problem hiding this comment.
Do you want me to change if for every/some as well?
There was a problem hiding this comment.
Might as well! Fits in this PR because it already touches those.
There was a problem hiding this comment.
changed item to chunk in all places except in one unrelated place.
benjamingr
reviewed
Feb 4, 2022
benjamingr
reviewed
Feb 4, 2022
benjamingr
reviewed
Feb 4, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Feb 5, 2022
Continue iterator-helpers work by adding `find` to readable streams.
27 tasks
29 tasks
|
Landed in 42ad413 |
|
It looks to me that this should be labelled as Also @Linkgoron should this be marked as a |
22 tasks
Some and every were, so I assume that it should be. |
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
Continue iterator-helpers work by adding `find` to readable streams. PR-URL: #41849 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836)
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836)
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836)
24 tasks
25 tasks
ruyadorno
added a commit
that referenced
this issue
Feb 10, 2022
Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836) PR-URL: #41897
ruyadorno
added a commit
that referenced
this issue
Feb 10, 2022
Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836) PR-URL: #41897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add find from the iterator-helper tc39 proposal.
I've also simplified some other things:
somenow usesfilter, and doesn't create an additional abort controllerthis.mapcalls replaced withmap.call<- as callingthis.mapcreates an additionalReadableThere is a behaviour change to some/every where
stream.destroyedisn't marked as destroyed synchronously, but needs an additional tick.