Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint rule that would fail for PRs containing subdmodule updates #74326

Open
malfet opened this issue Mar 16, 2022 · 0 comments
Open

Lint rule that would fail for PRs containing subdmodule updates #74326

malfet opened this issue Mar 16, 2022 · 0 comments
Labels
good first issue module: bootcamp module: ci triaged
Projects
PyTorch Dev Infra Backlog

Comments

@malfet
Copy link
Contributor

@malfet malfet commented Mar 16, 2022 •
edited by pytorch-bot bot

🚀 The feature, motivation and pitch

When submodules gets updated after checkout, devs often forget to run git submodule update command and propose PR that effectively reverts the update.

Prevent those accidental updates by requiring one to add "submodule-update" keyword to PR description before change can be merged.

Alternatives

No response

Additional context

No response

cc @seemethere @malfet @pytorch/pytorch-dev-infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue module: bootcamp module: ci triaged
Projects
PyTorch Dev Infra Backlog
Needs Triage
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@malfet @zou3519