-
Merge pull request #2226 from wesleycho/fix/ie9 …
wesleycho authoredfix(urlRouter): add check using `$sniffer` Fixes #2221
-
fix(urlRouter): add check using `$sniffer` …
wesleycho authored- Add additional check for situations where `pushState` is not properly supported
-
Merge pull request #2224 from epps/patch-1 …
nateabele authoreddocs(sample): change from plural 'states' to singular 'state'
-
Merge pull request #2212 from scooper91/statechangestart-options …
nateabele authoredfeat($stateChangeStart): Add options to event
-
feat($stateChangeStart): Add options to event …
scooper91 authored- Add options as a 5th parameter to the $stateChangeStart event - As per #1620
-
Merge pull request #2198 from jshado1/1902 …
nateabele authoredfix(UrlMatcherFactory): Correct trailing slash of terminal optional parameter
-
fix($stateParams): service instance reset between tests …
pkt-zer0 authoredA fresh object is created each time $stateParams is initialized, instead of reusing the same instance. This prevents leaking state between unit tests.
-
fix(UrlMatcherFactory): Correct trailing slash of terminal optional p… …
jshado1 authored…arameter Fixes #1902
-
Merge pull request #2065 from eddiemonge/issue_2064 …
nateabele authoredfix(urlMatcherFactory): include the slash in squashed params
-
Merge pull request #2187 from angular-ui/ui-state-directive …
nateabele authoredfeat(uiState): add ui-state directive
-
Merge pull request #2003 from metamatt/matt-view-load-events …
nateabele authoredfix(ui-view): change $viewContentLoading to pair with $viewContentLoaded
-
fix(urlMatcherFactory): include the slash in squashed params …
eddiemonge authoredSquashed params were ignoring a missing slash before the param so things like /users123 would match /url/:id Fixes #2064
-
Merge pull request #2012 from joshuahiggins/master …
nateabele authoredfeat(uiSrefActive): allow active & active-eq on same element
-
fix(ui-view): change $viewContentLoading to pair with $viewContentLoaded …
Matt Ginzton authoredThe old $viewContentLoaded event wasn't needed for the one internal client (ui-view) because ui-view always ignores that event and acts on a $stateChangeSuccess event that follows right behind anyway. And it wasn't as useful to external clients as it could be because it wasn't delivered on every view update -- it was delivered only on state transitions that activate a state defining a view, and didn't deal with inheritance. Also, neither $viewContentLoading nor $viewContentLoaded events contained the name of the view loading or loaded. This change makes $viewContentLoading and $viewContentLoaded be emitted always in pairs, before/after updateView does the work of actually loading the view, and both events include the name of the view being loaded. This is a breaking change for users of the old $viewContentLoading event that relied on it being broadcast from the root scope, the precise time it was broadcast, the fact that it wasn't always sent when a view is loaded even if $viewContentLoaded will be sent, or the "options" parameter that was emitted with it. If people rely on any of that behavior and we can't break it, then we can restore the old behavior but I think there needs to be some other event which is reliably paired with $viewContentLoaded and contains the view name, and I can't think of a better name than $viewContentLoading for that event. Closes #685.
-
Revert "refactor(commonjs): Added support for commonjs"
nateabele authored eddiemonge committed -
Merge pull request #1969 from eddiemonge/contrib …
nateabele authoreddocs(repo): updated contributing label images
-
Merge pull request #1960 from aaronroberson/master …
nateabele authoredrefactor(commonjs): Added support for commonjs
-
christopherthielen authored
-
christopherthielen authored
-
christopherthielen authored
-
fix($state): reloadOnSearch should not affect non-search param changes. …
Matt Ginzton authored christopherthielen committedThe handling of `reloadOnSearch: false` caused ui-router to avoid reloading the state in more cases than it should. The designed and documented behavior of this flag is to avoid state reload when the URL search string changes. It was also avoiding state reload when the URL path (or any non-search parameters to the state) changed, and even when state reload was explicitly requested. This change - flips the name of shouldTriggerReload (and the accompanying guard boolean, skipTriggerReloadCheck) to match the direction of the logic: shouldSkipReload and allowSkipReloadCheck - teaches shouldSkipReload to look at the types of the differing parameters, and only skip the reload if the only parameters that differ were search parameters - pulls the test for options.reload to the front of the complex boolean expression. - Updates $state.params and $stateParams when skipping reload Fixes #1079. Helps with one of the cases broken in #582.