Skip to content

Delete table #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Delete table #865

wants to merge 3 commits into from

Conversation

jmkucz
Copy link

@jmkucz jmkucz commented Dec 13, 2021

Change Summary

Provide summary of changes with issue number if any.

Change type

  • [ *] feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.
Added a delete table button on the tooltip menu

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@o1lab o1lab requested a review from pranavxc December 13, 2021 20:23
@o1lab
Copy link
Member

o1lab commented Dec 13, 2021

@jmkucz : thank you for this.

You would have to git sign it.

Please refer this.

pranavxc
pranavxc reviewed Dec 14, 2021
View reviewed changes
Copy link
Member

@pranavxc pranavxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a rebase

@wingkwong wingkwong added the 🏌️Status: Action Needed Some actions are needed to be done label Jan 28, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wingkwong wingkwong added the 🖋️ Status: CLA Needed Users haven't signed their CLA. label Mar 22, 2022
@o1lab
Copy link
Member

o1lab commented Mar 24, 2022

Closing this as the solution to delete table came from another PR from @vijayrathore8492

@o1lab o1lab closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavxc pranavxc pranavxc left review comments

Assignees
No one assigned
Labels
🏌️Status: Action Needed Some actions are needed to be done 🖋️ Status: CLA Needed Users haven't signed their CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmkucz @o1lab @CLAassistant @pranavxc @wingkwong