perf(@angular-devkit/core): use safe-stable-stringify #22057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fast-json-stable-stringify package with safe-stable-stringify. This improves the memoize performance and creating virtual ast objects. fast-json-stable-stringify x 18,765 ops/sec ±0.71% (94 runs sampled) safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled) There are two minor changes to the serialized output: 1. bigint are from now on serialized as number (this may be deactivated) and 2. the output for circular references now produces valid json (a string).
BridgeAR
force-pushed
the
switch-to-safe-stable-stringify
branch
from
066e237 to
a5046c1
Compare
|
Thank you for your contribution. However, we are looking into removing the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace fast-json-stable-stringify package with safe-stable-stringify.
This improves the memoize performance and creating virtual ast objects.
fast-json-stable-stringify x 18,765 ops/sec ±0.71% (94 runs sampled)
safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled)
There are two minor changes to the serialized output: 1. bigint are
from now on serialized as number (this may be deactivated) and 2. the
output for circular references now produces valid json (a string).