Skip to content
#

clean-architecture

Here are 4,407 public repositories matching this topic...

awesome-software-architecture
aalmuqahwi
aalmuqahwi commented Apr 23, 2021

https://github.com/kgrzybek/modular-monolith-with-ddd/blob/54d209639e501301e879aa0d0a84c9ea49e4689e/src/Modules/Meetings/Domain/Meetings/Rules/MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule.cs#L1-L21

I believe the comparison operator used in the IsBroken method is wrong because the rule is checking that meeting attendees limit must be greater than guests limit.

bug good first issue
dbrumann
dbrumann commented Jan 21, 2022

We can replace getType() and instead use an attribute on the collector-tag for registering them in the Registry under that name.

The depfile itself will not change. We need to modify the service configuration in config/services.php (add attributes to tag, inject tagged collectors into Registry by name) and change the Registry itself by assuming the iterable has the type as key, i.e. somethi

Improve this page

Add a description, image, and links to the clean-architecture topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the clean-architecture topic, visit your repo's landing page and select "manage topics."

Learn more