Skip to content
#

clean-code

Here are 1,685 public repositories matching this topic...

aalmuqahwi
aalmuqahwi commented Apr 23, 2021

https://github.com/kgrzybek/modular-monolith-with-ddd/blob/54d209639e501301e879aa0d0a84c9ea49e4689e/src/Modules/Meetings/Domain/Meetings/Rules/MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule.cs#L1-L21

I believe the comparison operator used in the IsBroken method is wrong because the rule is checking that meeting attendees limit must be greater than guests limit.

bug good first issue
04cfb1ed
04cfb1ed commented Oct 30, 2020
  • PHPMD version: 2.9.1
  • PHP Version: 7.4.10
  • Installation type: composer
  • Operating System / Distribution & Version: Windows 10 / Linux

Current Behavior

I'm trying to use exclude-pattern in a ruleset, but the same path doesn't work in windows/linux at the same time.

Usually I use a path like
<exclude-pattern>application/folder</exclude-pattern>

But, this only works for linux

Enhancement Good first issue

Improve this page

Add a description, image, and links to the clean-code topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the clean-code topic, visit your repo's landing page and select "manage topics."

Learn more