@nodejs/streams

I don't know to be honest as I don't want to make things too stringent. However adding a check is going to improve the developer experience.

What should the check do? Throw? emit 'error'?

I think:

1. cancel any further substeps
2. if stream was destroyed without error, override with error

Should we tag this as good first issue?

@ronag Can i take this up?

Go for it!

Hey! I was wondering about the status of this issue, and if I could try looking into it?

Go for it!

I went through Writable.js, but I'm not sure where should the checks be added. Specifically, I found these to be already present:

• _write at line 321 checks for state.destroyed before going to the user-provided _write function
• _final seems to be called through prefinish which also checks for state.destroyed at line 718

I'll really appreciate some guidance on this

You need to look at the time between those being called and their callback being invoked.

Thanks! I followed the code between these two times, and wanted to confirm the location. For _write, will it be appropriate to place the check inside onwrite() ?

This will be for the case when the stream gets destroyed during _write but no error is passed to the callback.

After looking into this, this seems to run counter to a previous pull request (maybe I didn't understand something?): #24062
Of course, the project requirements might have changed since then too.

I can't immediately see a way to throw an error at the start of the callbacks without changing/removing several of the tests. I also foresee some issues with asynchronous implementations of _write and _final (also in the tests). Do we want to go ahead with the change anyway?