Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI service names referenced in buildbots.rst #739

Merged
merged 1 commit into from Mar 2, 2022

Conversation

Copy link
Contributor

@nightlark nightlark commented Aug 18, 2021

Minor fix changing the CI service names referenced in buildbots.rst from AppVeyor and Travis which appear to have been replaced with GitHub Actions and Azure Pipelines for running tests on PRs.

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Aug 18, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@nightlark

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@nightlark
Copy link
Contributor Author

@nightlark nightlark commented Aug 21, 2021

The CLA bit is updated.

I'm trying to understand what the current state of CI services used is and when they are run -- I've seen issues that about switching to GitHub Actions (running for PRs+commits) from Travis (only running for commits), but it's not clear what the state of the transition is, and I'm not seeing anything about how the jobs on Azure Pipelines fit in.

Are there any pointers for where to look for additional documentation on the non-buildbot CI setup and what work is in progress/needs to get done? It would be nice to add more information on the CI setup to the devguide and figure out what work needs to get done, but so far with the scattered issues I've come across I feel like I need a guide to get me oriented on what is currently up to date. 😅

When working on a platform-specific issue, you may want to test your changes on
the buildbot fleet rather than just on Travis and AppVeyor. To do so, you can
the buildbot fleet rather than just on GitHub Actions and Azure Pipelines. To do so, you can
Copy link
Contributor Author

@nightlark nightlark Aug 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the only place in the entire devguide that mentions CI services other than the Python buildbot. Maybe it would be better to remove the outdated line, and later on add more detail on the non-buildbot CI setup?

Copy link
Member

@hugovk hugovk left a comment

Looks good, GHA and AP are now used in place of Travis and AppVeyor as the standard CI.

Copy link
Member

@Mariatta Mariatta left a comment

Thanks for updating.

@Mariatta Mariatta merged commit ec426f1 into python:main Mar 2, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants