feat: use solution-style tsconfigs for more accurate type checking #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodatea
reviewed
Jan 28, 2022
sodatea
reviewed
Jan 28, 2022
| if (needsCypress) { | ||
| render('tsconfig/cypress') | ||
| } | ||
| if (needsVitest) { |
There was a problem hiding this comment.
Only the Vitest template needs an additional tsconfig, because it runs in Node.js with JSDOM, which is different than other files under src/.
Cypress Component Testing runs in an actual browser, and the Cypress type definitions will be brought in by import { mount } from '@cypress/vue', so there's no need for a standalone tsconfig.
sodatea
reviewed
Jan 28, 2022
| "include": ["src/**/__tests__/*"], | ||
| "compilerOptions": { | ||
| "composite": true, | ||
| "types": ["node", "jsdom"] |
There was a problem hiding this comment.
I intentionally didn't include the Vitest types (which injects globals such as describe, it), because explicit is better than implicit.
|
Thank you for adding these comments explaining some decisions that were made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.