New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT use the default CPU_COUNT=2 for the macOS builds #22919
Conversation
According to Azure pipeline docs the Mac runners use 3 core CPUs. Looking at the threadpoolctl info, it looks like the docs could be wrong. |
Both are using mkl, which may not use all cpus (by default it does not use hyperthreads for instance). I think the most reliable would be to print |
Maybe it has changed and they did not keep the doc in sync. |
Hum actually the number of physical cores is probably incorrect since joblib will return the total number of cores anyway when the number of usable cores is limited. Better to just print cpu_count |
So indeed there are 3 cores according to joblib. But then the overall runtime does not seem to improve by using 3 |
I just noticed that the macOS builds might be slow because we use 3 pytest-xdist workers workers with just 2 CPUs for no apparent reason.
Let's try to see if using the default of 2 pytest-xdist workers improves the build time.