Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46429: tweak deepfreeze output #32107

Merged
merged 5 commits into from Mar 27, 2022
Merged

bpo-46429: tweak deepfreeze output #32107

merged 5 commits into from Mar 27, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 25, 2022 •
edited

https://bugs.python.org/issue46429

  • Generates better names for locals
  • Generates better names for ints

gvanrossum
gvanrossum reviewed Mar 25, 2022
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

I don’t like the new macro. It hides things I’d like to see clearly. The const_str thing is nice though.

arhadthedev
arhadthedev reviewed Mar 26, 2022
View changes
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
@kumaraditya303 kumaraditya303 requested a review from gvanrossum Mar 26, 2022
gvanrossum
gvanrossum reviewed Mar 27, 2022
View changes
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
@kumaraditya303 kumaraditya303 requested a review from gvanrossum Mar 27, 2022
gvanrossum
gvanrossum reviewed Mar 27, 2022
View changes
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
kumaraditya303
kumaraditya303 commented Mar 27, 2022
View changes
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
gvanrossum
gvanrossum approved these changes Mar 27, 2022
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Good!

@gvanrossum gvanrossum merged commit 785cc67 into python:main Mar 27, 2022
11 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Mar 27, 2022

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@kumaraditya303 kumaraditya303 deleted the tweak-deepfreeze branch Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kumaraditya303 @bedevere-bot @gvanrossum @arhadthedev @the-knights-who-say-ni