Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47127: Specialize calls for fastcall c functions with keywords #32125

Merged
merged 3 commits into from Mar 27, 2022
Merged

bpo-47127: Specialize calls for fastcall c functions with keywords #32125

merged 3 commits into from Mar 27, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 26, 2022 •
edited by bedevere-bot

Benchmark:

import pyperf

runner = pyperf.Runner()
runner.timeit(name="benchmark calls",
              stmt="a.decode();a.decode();a.decode();a.decode()",
              setup="a=b'a'*1000")

Result:

Mean +- std dev: [base] 2.16 us +- 0.12 us -> [patch] 1.68 us +- 0.06 us: 1.28x faster

It is the second largest specialization failure as per the stats.

https://bugs.python.org/issue47127

@kumaraditya303 kumaraditya303 changed the title specialization for fastcall with keywords for c functions bpo-47127: Specialize call for fastcall c functions with keywords Mar 26, 2022
@kumaraditya303 kumaraditya303 changed the title bpo-47127: Specialize call for fastcall c functions with keywords bpo-47127: Specialize calls for fastcall c functions with keywords Mar 26, 2022
@kumaraditya303 kumaraditya303 marked this pull request as ready for review Mar 26, 2022
Fidget-Spinner
Fidget-Spinner approved these changes Mar 26, 2022
View changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

LGTM.

@Fidget-Spinner Fidget-Spinner merged commit 58448cb into python:main Mar 27, 2022
12 checks passed
@kumaraditya303 kumaraditya303 deleted the fastcall branch Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

@markshannon markshannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot