Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #26689

Merged
merged 13 commits into from Jun 13, 2021
Merged

Fix typos #26689

merged 13 commits into from Jun 13, 2021

Conversation

@enjoy-binbin
Copy link
Contributor

@enjoy-binbin enjoy-binbin commented Jun 12, 2021

Correct minor spelling typos

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Jun 12, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@enjoy-binbin

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Lib/dataclasses.py Outdated Show resolved Hide resolved
Lib/plistlib.py Outdated Show resolved Hide resolved
@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 12, 2021

Why did you close this? The CLA? For spelling corrections, we merely prefer the CLA, but don't need it, as the change is from a 'creative' misspelling to the dictionary standard. You cannot copyright the correct spelling. I will apply this, but hope you go ahead and sign it now so you are ready for a future PR.

The initial Pipelines failure? It is a build failure, which should be unrelated to the PR and should be transient.

Lib/wsgiref/validate.py Outdated Show resolved Hide resolved
@enjoy-binbin
Copy link
Contributor Author

@enjoy-binbin enjoy-binbin commented Jun 12, 2021

@terryjreedy Hi. Thanks for your reply. I am new. That means a lot to me.
The only reason i closed it because the CLA... I have applied for the sign, juse wait the result
So that i can reopen again. Avoid disturbing you guys. But it seems that you have been mentioned

Thanks again for your time!

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 12, 2021

Reverting configure.ac did not work, so I made sure updated to latest main.

@cjw296 cjw296 removed their request for review Jun 12, 2021
@cjw296
Copy link
Contributor

@cjw296 cjw296 commented Jun 12, 2021

@terryjreedy - be careful with this one, I spotted some changes that weren't good.

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 12, 2021

@cjw296 Please be specific. A couple of hours ago I reviewed carefully and already reverted, corrected, or checked everything I though questionable.

@terryjreedy terryjreedy reopened this Jun 12, 2021
@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 12, 2021

@cjw296 I recheck and found this: in ssl.py, 'woth' should by 'with', not 'worth'. Fixed. I think others looks good in context.

@isidentical isidentical removed their request for review Jun 12, 2021
@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 12, 2021

Bin-bin, If you (or anyone else) are on Linux and can run 'make regen-all' and commet whatever that changes, please try that.

Copy link
Member

@ericvsmith ericvsmith left a comment

I'm not on Linux right now, so I can't help with 'make regen-all', sorry.

But all of the corrections look good to me. Thanks, @enjoy-binbin and @terryjreedy.

@enjoy-binbin
Copy link
Contributor Author

@enjoy-binbin enjoy-binbin commented Jun 13, 2021

@terryjreedy It seems that re-gen was ok. I was trying to solve that one half hour ago.
But i only have a centos and i encounter some problems.
Now look like the hardest part has been solved.

Sorry for that, i didn't expect to cause this problem... and others minor fix
Thanks a lot, it must have cost you a lot of time

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 13, 2021

On corementorship, Guido said how to rebuild on windows: PCbuild\build -r. importlib_external.h was rebuilt, followed by errors that disappeared on rerun. I will redo the the misspellings I reverted and is that does not create a problem, merge.

@terryjreedy terryjreedy merged commit 17b16e1 into python:main Jun 13, 2021
13 checks passed
13 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL (1.1.1k)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (3.0.0-alpha17)
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210613.2 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 13, 2021

Thanks @enjoy-binbin for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 13, 2021

Sorry, @enjoy-binbin and @terryjreedy, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 17b16e13bb444001534ed6fccb459084596c8bcf 3.10

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 13, 2021

Yes, more time than expected. At least I learned that rebuilding can be done on Windows. I have seen the make message before and assumed I had to have a make system. Another core def suggested that the error message should be more informative.

I expected that auto backport would fail even though most of these misspelling either originated with or were backported at least to 3.10. If you do a 3.10 backport that passes tests , I will review and merge. Using the cherry_picker module is easier than git cherry-picker as it automates more. Whether and how are up to you.

enjoy-binbin added a commit to enjoy-binbin/cpython that referenced this pull request Jun 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 17b16e1)
@enjoy-binbin enjoy-binbin deleted the enjoy-binbin:fix_typos branch Jun 13, 2021
enjoy-binbin added a commit to enjoy-binbin/cpython that referenced this pull request Jun 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>.
(cherry picked from commit 17b16e1)

Co-authored-by: Binbin <binloveplay1314@qq.com>
jdevries3133 added a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment