bpo-43166: Disable ceval.c optimizations for Windows debug builds again #32023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small improvement on GitHub test machines.
|
zooba
reviewed
Mar 21, 2022
zooba
reviewed
Mar 21, 2022
|
Thanks! |
asvetlov
added a commit
to YvesDup/cpython
that referenced
this issue
Mar 25, 2022
…thonGH-32023) Also increases the stack allocation when run with `python_d.exe` to account for the extra stack checks that are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Debug builds' optimization could be reconsidered as
3.11a6+has reduced the stack usage. Disabling on MSVC should fix the build performance regression and make ceval.c debuggable.test_xml_etree, which is the top stack consumer among 17 tests mentioned in bpo-43271, requires the following bytes:They include 200,000 bytes usage with /Ob1 (OnlyExplicitInline) option introduced by #10094 for running performance.
https://bugs.python.org/issue43166