[Finder] Restore Finder:getIterator return type PHPDoc #44731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
No dear bot @carsonbot, this one is a GitHub issue: community/community#5634 |
|
oh, I was not aware of the fact that this feature was not available for forks belonging to an organization. Maybe carsonbot could detect that case. |
carsonbot
changed the title
fancyweb
approved these changes
Dec 20, 2021
derrabus
approved these changes
Dec 20, 2021
|
@stof or GitHub will fix this, I didn't know about this as well, until carsonbot's message, doesn't look like a feature. |
|
Good catch, thanks @kubawerlos. |
fabpot
added a commit
that referenced
this pull request
Dec 21, 2021
…ovariant IteratorAggregate implementations (derrabus) This PR was merged into the 6.0 branch. Discussion ---------- [EventDispatcher][HttpFoundation] Restore return type to covariant IteratorAggregate implementations | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Follows #44731 | License | MIT | Doc PR | N/A Commits ------- 0f2b5bb Restore return type to covariant IteratorAggregate implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the related ticket we want this annotation back. Targeting
6.0as it is present in5.4, was remove during merging5.4up to6.0.