Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] profiler ignores framework.validation.translation_domain: false setting #45848

Open
jennevdmeer opened this issue Mar 25, 2022 · 5 comments
Open

[WebProfilerBundle] profiler ignores framework.validation.translation_domain: false setting #45848

jennevdmeer opened this issue Mar 25, 2022 · 5 comments
Labels
Bug Form Status: Needs Review WebProfilerBundle

Comments

@jennevdmeer
Copy link
Contributor

jennevdmeer commented Mar 25, 2022 •
edited

Symfony version(s) affected

5.4

Description

When disabling validator translations according to https://symfony.com/doc/current/reference/configuration/framework.html#translation-domain by setting it to false.

config/validator.yaml

framework:
    validation:
        translation_domain: false

The profiler still shows them as being missing translation messages.

How to reproduce

I have a simple repro (basic create project website/skeleton + form, templates, translator and validator) can be ran with php -S http://127.0.0.1:8000 -t public and then just clicking the submit button.

https://github.com/jennevdmeer/Symfony-WebProfilerBundle-ignores-framework.validation.translation_domain--false-setting

Possible Solution

No response

Additional Context

Toolbar:
image

Profiler:
image
@xabbuh
Copy link
Member

xabbuh commented Mar 25, 2022

Reading the code I fail to see how this could have worked before (the docs were updated to account for false in symfony/symfony-docs#13371).

@jennevdmeer
Copy link
Contributor Author

jennevdmeer commented Mar 25, 2022 •
edited

Reading the code I fail to see how this could have worked before (the docs were updated to account for false in symfony/symfony-docs#13371).

I'm confused as to what you are trying to say here. Are you talking about affected version? Because I just entered what I'm currently using in my project. It could have well been like this since it was introduced.

Another note on the issue me guessing it just replaces the translation domain to empty but still goes through the translation process. Just due to not having a name, no file is hit. Though I haven't tried just a .nl.yaml file.

@carsonbot
Copy link

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

@carsonbot
Copy link

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

@jennevdmeer
Copy link
Contributor Author

Still relevant, nothing has changed afaik.

@carsonbot carsonbot removed the Stalled label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jennevdmeer @xabbuh @carsonbot