[Validator] Improve FileValidator sizes factorization edge case #45093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 20, 2022
src/Symfony/Component/Validator/Tests/Constraints/FileValidatorTest.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
validator/file-factorize
branch
2 times, most recently
from
e3e7ca1 to
27d0494
Compare
fancyweb
force-pushed
the
validator/file-factorize
branch
from
27d0494 to
e95fd72
Compare
fancyweb
force-pushed
the
validator/file-factorize
branch
from
e95fd72 to
054295a
Compare
fancyweb
force-pushed
the
validator/file-factorize
branch
from
054295a to
6f9fdaa
Compare
stof
approved these changes
Apr 12, 2022
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading a
169_630 bytesfiles (169.63 KB), I get:Displaying an allowed maximum size in MB while the maximum I specified is lower than 1 MB is not optimal IMO.
Most of the time the problem doesn't occur because the first division result in
FileValidator::factorizeSizes()is a number < 1 but it has more than 2 decimals, so it's still go in the "while" loop. It's visible only with specific values, when the division result "tombe juste 🇫🇷".For example, If I change the maximum allowed size a bit:
I get: