Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
chore(README): add the supported locales for various validators #1266
Comments
@profnandaa i was thinking about fixing it the other day and i had a little concern, should we rename |
@tux-tn -- sure, standardization will be great. However, we will have backward compatibility to deal with. |
@profnandaa can i work on a PR where we can accept a string and an array as a parameter and rename it to locale in the documentation? |
@tux-tn -- can give an example? |
@profnandaa: It looks like the documentation side of things has already been handled from looking at the README, so is this issue now for removing instances of From doing a quick search through the code base, it looks like we could rename the remaining parameters without causing backwards compatibility issues, and I'll be happy to submit a PR if this is true |
@jmartin4563 -- sure, the issue will be mainly dealing with backward compatibility. I'm more of the idea that we go for CC for stuff that's territorial, and I know this contradicts with what we've done already with stuff like PostalCode, PhoneNumber, etc... what would be your suggestion? |
@profnandaa Started work on adding 'DE' locale for |
e.g.
isPassportNumber
, etc.