Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(README): add the supported locales for various validators #1266

Open
profnandaa opened this issue Mar 5, 2020 · 7 comments
Open

chore(README): add the supported locales for various validators #1266

profnandaa opened this issue Mar 5, 2020 · 7 comments

Comments

@profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Mar 5, 2020

e.g. isPassportNumber, etc.

@tux-tn
Copy link
Contributor

@tux-tn tux-tn commented Mar 13, 2020

@profnandaa i was thinking about fixing it the other day and i had a little concern, should we rename countryCode to locale to have consistent naming across the lib?

@profnandaa
Copy link
Collaborator Author

@profnandaa profnandaa commented Mar 15, 2020

@tux-tn -- sure, standardization will be great. However, we will have backward compatibility to deal with.

@tux-tn
Copy link
Contributor

@tux-tn tux-tn commented Mar 16, 2020

@profnandaa can i work on a PR where we can accept a string and an array as a parameter and rename it to locale in the documentation?

@profnandaa
Copy link
Collaborator Author

@profnandaa profnandaa commented Mar 22, 2020

@tux-tn -- can give an example?

@jmartin4563
Copy link

@jmartin4563 jmartin4563 commented Oct 10, 2020

@profnandaa: It looks like the documentation side of things has already been handled from looking at the README, so is this issue now for removing instances of countryCode as parameter names and replacing them with locale?

From doing a quick search through the code base, it looks like we could rename the remaining parameters without causing backwards compatibility issues, and I'll be happy to submit a PR if this is true

@profnandaa
Copy link
Collaborator Author

@profnandaa profnandaa commented Oct 10, 2020

@jmartin4563 -- sure, the issue will be mainly dealing with backward compatibility. I'm more of the idea that we go for CC for stuff that's territorial, and I know this contradicts with what we've done already with stuff like PostalCode, PhoneNumber, etc... what would be your suggestion?

@firlus
Copy link
Contributor

@firlus firlus commented Oct 18, 2020

@profnandaa Started work on adding 'DE' locale for isTaxID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.