Skip to content

Add source map support and clean test dependencies #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

aeisenberg
Copy link
Contributor

  1. Source map support means that stack traces will point to the *.ts
    file instead of the generated *.js file
  2. Cleaning test dependencies means moving all mocha and chai
    registration into the respective index files and removing unnecessary
    imports.

Development only. No user facing changes.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg aeisenberg requested a review from a team as a code owner March 30, 2022 18:44
@aeisenberg aeisenberg force-pushed the aeisenberg/source-map-support branch from 700773a to 5a1b32c Compare March 30, 2022 18:53
1. Source map support means that stack traces will point to the *.ts
   file instead of the generated *.js file
2. Cleaning test dependencies means moving all mocha and chai
   registration into the respective index files and removing unnecessary
   imports.
@aeisenberg aeisenberg force-pushed the aeisenberg/source-map-support branch from 5a1b32c to 35e9da8 Compare March 30, 2022 19:30
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! 😃

@aeisenberg aeisenberg merged commit 04f72a7 into main Mar 31, 2022
@aeisenberg aeisenberg deleted the aeisenberg/source-map-support branch March 31, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants