Add warning message if model uses input_ids that include padding tokens, but no attention_mask is provided.
#16136
Comments
|
Models usually don't know the right pad token ID as pointed out in the issue (I'm also not sure that community-contributed models or models not as heavily used as BERT have the right pas token ID in their configs), so I'm not in favor of this. Plus, the check of the inputs at each forward pass would slow down performance. I agree that it's a common error, and it would make a very nice addition to the troubleshooting guide IMO, but I'm not sure we can add anything in the library to properly warn users without hurting performance or having a lot of false alarms. |
|
Hmm, think we can be pretty confident that |
|
Yay more content for the troubleshooting guide! I'll work on a PR for this |
First good issue
A current error is that a user forwards a batched tensor of
input_idsthat include a padding token, e.g.input_ids = torch.tensor([["hello", "this", "is", "a", "long", "string"], ["hello", "<pad>", "<pad>", "<pad>", "<pad>"]]In this case, the
attention_maskshould be provided as well. Otherwise the output hidden_states will be incorrectly computed. This is quite a common silent error IMO.With @LysandreJik @sgugger, we have decided to not automatically create the
attention_maskthat masks out the padding tokens in this case because of the reasons explains here: #15479 (comment) . However as pointed out in #15479, we should IMO at least displa a warning since this error happens a lot IMO.As a first good issue, one could add such a warning to the BertModel in a first case which would go something like:
What do you think @sgugger @LysandreJik ?
The text was updated successfully, but these errors were encountered: