Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH #27623

Merged
merged 1 commit into from Aug 6, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 6, 2021

Fix the os.set_inheritable() functon on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.

https://bugs.python.org/issue44849

@vstinner
Copy link
Member Author

@vstinner vstinner commented Aug 6, 2021

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
@vstinner
Copy link
Member Author

@vstinner vstinner commented Aug 6, 2021

Oops, I fixed a typo: functon => function.

@vstinner vstinner force-pushed the set_inheritable_o_path branch from eb6c225 to 8a0695e Compare Aug 6, 2021
@vstinner vstinner merged commit c24896c into python:main Aug 6, 2021
13 checks passed
@vstinner vstinner deleted the set_inheritable_o_path branch Aug 6, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Sorry @vstinner, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c24896c0e3b32c8a9f614ef51366007b67d5c665 3.10

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 6, 2021
…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2021

GH-27630 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 6, 2021
…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2021

GH-27631 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Aug 6, 2021
Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this issue Aug 6, 2021
Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 15, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 15, 2021

GH-28978 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this issue Oct 19, 2021
…) (GH-28978)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants