Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for OK packets representing EOF #805

Open
julienschmidt opened this issue May 23, 2018 · 2 comments · May be fixed by #962
Open

Support for OK packets representing EOF #805

julienschmidt opened this issue May 23, 2018 · 2 comments · May be fixed by #962
Labels
enhancement good first issue
Milestone
v1.7.0

Comments

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented May 23, 2018

EOF packets are deprecated. MySQL servers 5.7.5 and up instead send OK packets that signal an EOF, if the client advertises support: https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_ok_packet.html
@julienschmidt julienschmidt added this to the v1.5.0 milestone May 23, 2018
nemith added a commit to nemith/mysql that referenced this issue May 1, 2019
@nemith
WIP: Add support for OK packets representing EOF
c57020b 
Fixes: go-sql-driver#805
@nemith nemith linked a pull request that will close this issue May 1, 2019
Open
5 tasks
@marti1125
Copy link

@marti1125 marti1125 commented Sep 16, 2019

Hi, I am interesting in contribute with this. Could you tell me more? how to I can get start?
@methane
Copy link
Member

@methane methane commented Sep 17, 2019

@marti1125 There is a pull request (#962) for fixing this. So you can get started by:

  1. Understand MySQL protocol by reading documents and packets (using Wireshark).
  2. Review and test #962.
@julienschmidt julienschmidt removed this from the v1.5.0 milestone Sep 30, 2019
@julienschmidt julienschmidt added this to the v1.6.0 milestone Sep 30, 2019
tz70s added a commit to tz70s/mysql that referenced this issue Sep 5, 2020
@nemith @tz70s
Add support for OK packets representing EOF
c29ba2b 
Fixes: go-sql-driver#805
tz70s added a commit to tz70s/mysql that referenced this issue Sep 5, 2020
@nemith @tz70s
Add support for OK packets representing EOF
c34acf9 
Fixes: go-sql-driver#805
@julienschmidt julienschmidt removed this from the v1.6.0 milestone Apr 1, 2021
@julienschmidt julienschmidt added this to the v1.7.0 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
v1.7.0
Linked pull requests

Successfully merging a pull request may close this issue.

WIP: Add support for OK packets representing EOF
3 participants
@methane @marti1125 @julienschmidt