Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Dockerfile and GitHub action to smoke-test RedHat compatibility #5437

Merged
merged 4 commits into from Feb 9, 2022
Merged

add Dockerfile and GitHub action to smoke-test RedHat compatibility #5437

merged 4 commits into from Feb 9, 2022

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Feb 7, 2022 •
edited

This PR contains changes to smoke-test LocalStack against RedHat / rpm based operating systems:

  • Add a Dockerfile.rh which is based on redhat/ubi8 in order to build LocalStack on a RedHat / rpm based system.
    • This Dockerfile - in contrast to the default Dockerfile - does not add the latest source code to the image, but installs the latest packages from PyPi. This means that the image may not contain the latest changes in the repo.
  • Add a new GitHub action (smoke-tests-against-redhat) to build the image and perform the CI smoke tests.
  • Removes the deprecated infra make target (since there is no code in the RedHat Docker image).

What's left to do:

  • Add changes to our extensions (installing libs is currently not working).
  • Make sure the GitHub action works correctly.
  • Change the GitHub action trigger to a fixed schedule (as it's not coupled to the source code directly).

@alexrashed alexrashed temporarily deployed to localstack-ext-tests Feb 7, 2022 Inactive
@alexrashed alexrashed requested a review from whummer Feb 7, 2022
@alexrashed alexrashed had a problem deploying to localstack-ext-tests Feb 7, 2022 Failure
@coveralls
Copy link

@coveralls coveralls commented Feb 7, 2022 •
edited

Coverage Status

Coverage decreased (-0.04%) to 84.212% when pulling 179c633 on redhat-support into e2d0407 on master.

@github-actions
Copy link

@github-actions github-actions bot commented Feb 7, 2022 •
edited

LocalStack integration with Pro

       3 files  ±0      3 suites  ±0   59m 17s ⏱️ +6s
   836 tests ±0  800 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
1 038 runs  ±0  981 ✔️ ±0  57 💤 ±0  0 ❌ ±0 

Results for commit 179c633. ± Comparison against base commit e2d0407.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests Feb 8, 2022 Inactive
whummer
whummer approved these changes Feb 8, 2022
View changes
Copy link
Member

@whummer whummer left a comment

Awesome set of changes @alexrashed ! 💯 Great to see Redhat smoke tests being added to our pipeline.

Dockerfile.rh Outdated Show resolved Hide resolved
bin/supervisord.conf Show resolved Hide resolved
.github/workflows/rh-support.yml Show resolved Hide resolved
@alexrashed alexrashed had a problem deploying to localstack-ext-tests Feb 9, 2022 Failure
@alexrashed alexrashed had a problem deploying to localstack-ext-tests Feb 9, 2022 Failure
@alexrashed alexrashed temporarily deployed to localstack-ext-tests Feb 9, 2022 Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests Feb 9, 2022 Inactive
@alexrashed alexrashed marked this pull request as ready for review Feb 9, 2022
@alexrashed alexrashed merged commit d7f04fd into master Feb 9, 2022
1 of 2 checks passed
@alexrashed alexrashed deleted the redhat-support branch Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexrashed @coveralls @whummer