Skip to content

fix: CI workflow not being able to commit to the master branch #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 2, 2022
Merged

fix: CI workflow not being able to commit to the master branch #1840

merged 4 commits into from
Jan 2, 2022

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Nov 7, 2021 •
edited by gitpod-io bot
Loading

Description of Change

  • Fix the CI workflow not being able to commit to the master branch.
    • This is due to the branch protection: we cannot add github-actions as administrator to skip the protection. So let's add my name which has administrator permissions, that should work.
      UNTESTED, might not work.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7
fix: CI workflow not being able to commit to...
13f6a7a 
...the `master` branch.
This is due to the branch protection: we cannot add `github-actions` as administrator to skip the protection. So let's add my name which has administrator permissions, that should work.

UNTESTED, might not work.
@Panquesito7 Panquesito7 added the enhancement New feature or request label Nov 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Dec 8, 2021
@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Dec 8, 2021
@github-actions github-actions bot added the approved Approved; waiting for merge label Jan 1, 2022
@Panquesito7 Panquesito7 merged commit fe692e8 into master Jan 2, 2022
@Panquesito7 Panquesito7 deleted the fix_ci branch January 2, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@Qannaf Qannaf Qannaf approved these changes

@mishraabhinn mishraabhinn Awaiting requested review from mishraabhinn

@aminoxix aminoxix Awaiting requested review from aminoxix

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panquesito7 @ayaankhan98 @Qannaf