bpo-46996: Remove support of Tcl/Tk < 8.5.12 #31839
Conversation
serhiy-storchaka
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
Lib/test/test_tcl.py
Outdated
| v = get_tk_patchlevel() | ||
| if v >= (8, 6, 0, 'final') or (8, 5, 8) <= v < (8, 6): | ||
| integers += (2**63, -2**63-1, 2**1000, -2**1000) | ||
| integers += (2**63, -2**63-1, 2**1000, -2**1000) |
There was a problem hiding this comment.
If a condition is unlocked, maybe there is a sense to group numbers into (N-1, -N, N, -N-1).
def get_integers(self):
return (0, 1, -1,
2**31-1, -2**31, 2**31, -2**31-1,
2**63-1, -2**63 ,2**63, -2**63-1,
2**1000, -2**1000)There was a problem hiding this comment.
I thought about this, but kept simpler diff because there is already many changes in this PR.
But if you also suggest this I'll rewrite this code.
|
Thanks, Serhiy! Do you want to merge this before GH-31698? |
|
What is better for you? Does this PR need some changes in the build scripts or you will add them in #31698? |
|
Any order is fine with me. GH-31698 requires only minimal adjustments after this has been merged, so we can go for this first. |
https://bugs.python.org/issue46996