Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages #346

Open
mtrunkat opened this issue Mar 20, 2019 · 1 comment
Open

Improve error messages #346

mtrunkat opened this issue Mar 20, 2019 · 1 comment
Labels
good first issue
Projects
Pardubice Hackathon

Comments

@mtrunkat
Copy link
Member

@mtrunkat mtrunkat commented Mar 20, 2019

For example Error: PuppeteerCrawler: handlePageFunction timed out. could contain instruction how to increase the timeout.
@mnmkng
Copy link
Member

@mnmkng mnmkng commented Mar 21, 2019

Typechecks on public functions should fail fast. Providing an undefined url to rq.addRequest() goes tovalidateAddRequestParams -> new Request -> checkParamOrThrow before throwing. This produces an error message that is very hard to understand.

@mtrunkat mtrunkat added this to To do in Pardubice Hackathon via automation Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
No open projects
Pardubice Hackathon
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtrunkat @mnmkng