static-code-analysis

~/code/rubocop$ grep -iro "autocorrect" . | wc -l
    1971
~/code/rubocop$ grep -iro "auto-correct" . | wc -l
    1551

Both autocorrect and auto-correct are used frequently in RuboCop. Should we be consistent? If so, which one?

Any change should only affect comments and other string content, not method names.

Describe the bug
Patterns for Go multiple return values match more strictly than the argument list, which is confusing.

To Reproduce
Try to match any Go function that has error in the return type list. All six of these functions should match:

func a(b int) error { return nil }
func b() (int, error) { return 0, nil }
func c() (error, int) { return nil, 0 }
func d() (float6

Is your feature request related to a problem? Please describe.
We have a file pkg/policy/defaultRules.yaml - which is the source of truth for the default rules in users' policies.
It's very important we don't break it, therefore - better testing is required.
A quick win would be to test and validate the structure of the yaml

Describe the solution you'd like
Add a test file **pkg/pol

Many repositories need to fix, so please help if you like.

If you could help, it would be helpful if you could comment before starting the work not to overlapping.

Fix example

Run exit command after lint.

echo '::group:: Running golangci-lint with reviewdog 🐶 ...'
go

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. create .bandit file with content:

[bandit]
tests: B101,B102,B301

2. run bandit -c .bandit -r module/
3. get error:
   [main] ERROR .bandit : Error parsing file.

Expected behavior
working as described in readme

Bandit version

ba

Bug description

Two issues with bad-string-format-type:

1. Just like bad-format-character the bad-string-format-type message is currently only raised for old-style string formatting.
2. If only a single value needs to be formatted, the check does not work if the value to format is passed in as a variable. Using variables in tuples however is fine.

Given a file a.py:

Affects PMD Version:
6.17

Rule:
All rulesets.

Description:
PMD output does not inform the user as to the number of rules contravened while running the tool. The user has to look at the output file.

Code Sample demonstrating the issue:

Sep 01, 2019 9:42:45 AM net.sourceforge.pmd.cache.FileAnalysisCache loadFromFile
INFO: Analysis cache loaded
Sep 01, 2019 9:

Elm has the option to output errors as JSON (via a flag), and something like that is handy for writing tooling around it. I'm trying to integrate pytype into ALE and this would make it a lot easier.

Is your feature request related to a problem? Please describe.
It would be nice that imports-blacklist rule supports regex or match any sub-packages.

Describe the solution you'd like
adding
[rule.imports-blacklist]
arguments = ["github.com/pkgA/pkgB", "github.com/pkg1/**/pkg2"]
configuration would prevent following imports:
import "github.com/pkgA/pkgB"
import "github.com/pkgA

This would allow for more localized suppressions. Say we have a method foo(Object o) in an annotated third-party library where o has no type annotation, but o really should be @Nullable, as foo() can handle being passed null as a parameter. In code checked by NullAway, say you write:

void bigMethod() {
  ...
  foo(null); // NullAway reports an error
  ...
}

I beli

https://github.com/spotbugs/spotbugs/blob/818b14cee799caffc9cc0ceefa560e24b82921ce/spotbugs/etc/messages.xml#L7761

should be changed to

for oddness, consider using (x & 1) == 1, or (x % 2) != 0.

I wrote some of the code to do this in a branch https://github.com/python-security/pyt/compare/class_based_views, but since I'm working on other things and this feature seems cool and important I'm making this issue 👍

Let me know if you would like any help in implementing.

kube-score is linted with golangci-lint, but some of the linters have been disabled.

1. Update .golangci.yml to enable more linters
2. Run golangci-lint run to find the issues that the new linters find.
3. Fix the issues until none are left.
4. Send a PR! 😍

Rubberduck version information
The info below can be copy-paste-completed from the first lines of Rubberduck's log or the About box:

Rubberduck version [Version 2.5.2.6030
OS: Microsoft Windows NT 10.0.22000.0, x64
Host Product: Microsoft Office x64
Host Version: 16.0.14701.20226
Host Executable: WINWORD.EXE

Description
Language inspection for assignment of LCase suggests usi